Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255710: Opensource unit/regression tests for CMM #1615

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 28, 2022

Hi all,
This pull request contains a backport of commit 98ccfbf4 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Jan 2021 and was reviewed by Pankaj Bansal and Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255710: Opensource unit/regression tests for CMM

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1615/head:pull/1615
$ git checkout pull/1615

Update a local copy of the PR:
$ git checkout pull/1615
$ git pull https://git.openjdk.org/jdk11u-dev pull/1615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1615

View PR using the GUI difftool:
$ git pr show -t 1615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1615.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 98ccfbf46915791208f80b51f68f3916a68b8aaf 8255710: Opensource unit/regression tests for CMM Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255710: Opensource unit/regression tests for CMM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 28, 2022
@mrserb mrserb marked this pull request as ready for review December 28, 2022 06:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 28, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 28, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit 4640c05.
Since your change was applied there have been 4 commits pushed to the master branch:

  • a3f37e5: 8298027: Remove SCCS id's from awt jtreg tests
  • 96fded9: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • b5e97ee: Merge
  • 445ab52: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@mrserb Pushed as commit 4640c05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant