Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8230731: SA tests fail with "Windbg Error: ReadVirtual failed" #1619

Closed
wants to merge 1 commit into from
Closed

8230731: SA tests fail with "Windbg Error: ReadVirtual failed" #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/jdk.hotspot.agent/windows/native/libsaproc/sawindbg.cpp
View file
Open in desktop
Expand Up @@ -742,11 +742,9 @@ JNIEXPORT jbyteArray JNICALL Java_sun_jvm_hotspot_debugger_windbg_WindbgDebugger
CHECK_EXCEPTION_(0);

ULONG bytesRead;
COM_VERIFY_OK_(ptrIDebugDataSpaces->ReadVirtual((ULONG64)address, arrayBytes,
(ULONG)numBytes, &bytesRead),
"Windbg Error: ReadVirtual failed!", 0);

if (bytesRead != numBytes) {
const HRESULT hr = ptrIDebugDataSpaces->ReadVirtual((ULONG64)address, arrayBytes,
(ULONG)numBytes, &bytesRead);
if (hr != S_OK || bytesRead != numBytes) {
return 0;
}

Expand Down