Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off #1625

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 31, 2022

I backport this for parity with 11.0.19-oracle.

I resolved the ProblemList, will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1625/head:pull/1625
$ git checkout pull/1625

Update a local copy of the PR:
$ git checkout pull/1625
$ git pull https://git.openjdk.org/jdk11u-dev pull/1625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1625

View PR using the GUI difftool:
$ git pr show -t 1625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1625.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 649f2d8835027128c6c8cf37236808094a12a35f 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off Dec 31, 2022
@openjdk
Copy link

openjdk bot commented Dec 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 31, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

Going to push as commit f6aef8a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d1f6bd1: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432
  • c898a3e: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • 5971a6a: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 984e456: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
  • d52365e: 8230731: SA tests fail with "Windbg Error: ReadVirtual failed"
  • ffc2ced: 8212216: JGSS: Fix leak in exception cases in getJavaOID()
  • 4c2ff08: 8212165: JGSS: Fix cut/paste error in NativeUtil.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2023
@openjdk openjdk bot closed this Jan 2, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 2, 2023
@GoeLin GoeLin deleted the goetz_backport_8065097 branch January 2, 2023 11:49
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@GoeLin Pushed as commit f6aef8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant