Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" #1630

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 3, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1630/head:pull/1630
$ git checkout pull/1630

Update a local copy of the PR:
$ git checkout pull/1630
$ git pull https://git.openjdk.org/jdk11u-dev pull/1630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1630

View PR using the GUI difftool:
$ git pr show -t 1630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1630.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4bdd1c914859e221c64208d47ef309d463609953 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 62191cd: 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

Going to push as commit e92b7c3.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 369dedb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • 80eecc5: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • dfcf7c1: 8256111: Create implementation for NSAccessibilityStaticText protocol
  • 06f769a: 8292863: assert(_print_inlining_stream->size() > 0) failed: missing inlining msg
  • 1d78ce4: 8221351: Crash in KlassFactory::check_shared_class_file_load_hook
  • 3c2763f: 8195716: BootstrapLoggerTest : Executor still alive
  • decfc86: 8217353: java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java fails with Unexpected reference: java.lang.ref.WeakReference
  • dc5590f: 8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order
  • 1713cf1: 8215759: [test] java/math/BigInteger/ModPow.java can throw an ArithmeticException
  • 13eadde: 8215372: test/jdk/java/nio/file/DirectoryStream/Basic.java not correct when using a glob
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/f9f3fcb9e5fb5050008d72b5c7c37ea4a0ebccfa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023
@openjdk openjdk bot closed this Jan 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@GoeLin Pushed as commit e92b7c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant