Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378 #1651

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 12, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1651/head:pull/1651
$ git checkout pull/1651

Update a local copy of the PR:
$ git checkout pull/1651
$ git pull https://git.openjdk.org/jdk11u-dev pull/1651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1651

View PR using the GUI difftool:
$ git pr show -t 1651

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1651.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/1650 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2f47f83addd7f69db2c7070552a7ec67bd07d62e 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378 Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

@GoeLin GoeLin changed the base branch from pr/1650 to master January 16, 2023 17:54
@openjdk openjdk bot removed the clean label Jan 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 16, 2023

/clean

This was clean before. The merge is empty.

@openjdk openjdk bot added the clean label Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit 71e89e1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin Pushed as commit 71e89e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8297569 branch January 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant