New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285093: Introduce UTIL_ARG_WITH #1718
8285093: Introduce UTIL_ARG_WITH #1718
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8285755 |
@RealCLanger |
/issue add JDK-8285919 |
@RealCLanger |
4fab450
to
2b3f3e8
Compare
@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d7a6e6a.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit d7a6e6a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This backport enables backporting of JDK-8293550. I had to manually accept one hunk. I've also included the minor fixes for JDK-8285755 and JDK-8285919 inline.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1718/head:pull/1718
$ git checkout pull/1718
Update a local copy of the PR:
$ git checkout pull/1718
$ git pull https://git.openjdk.org/jdk11u-dev pull/1718/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1718
View PR using the GUI difftool:
$ git pr show -t 1718
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1718.diff