Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285093: Introduce UTIL_ARG_WITH #1718

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Feb 10, 2023

This backport enables backporting of JDK-8293550. I had to manually accept one hunk. I've also included the minor fixes for JDK-8285755 and JDK-8285919 inline.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1718/head:pull/1718
$ git checkout pull/1718

Update a local copy of the PR:
$ git checkout pull/1718
$ git pull https://git.openjdk.org/jdk11u-dev pull/1718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1718

View PR using the GUI difftool:
$ git pr show -t 1718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1718.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b77b574685ee043dfce2b5b17cb0f166b339485 8285093: Introduce UTIL_ARG_WITH Feb 10, 2023
@openjdk
Copy link

openjdk bot commented Feb 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 10, 2023
@RealCLanger
Copy link
Contributor Author

/issue add JDK-8285755

@openjdk
Copy link

openjdk bot commented Feb 10, 2023

@RealCLanger
Adding additional issue to issue list: 8285755: JDK-8285093 changed the default for --with-output-sync.

@RealCLanger
Copy link
Contributor Author

/issue add JDK-8285919

@openjdk
Copy link

openjdk bot commented Feb 10, 2023

@RealCLanger
Adding additional issue to issue list: 8285919: Remove debug printout from JDK-8285093.

@mlbridge
Copy link

mlbridge bot commented Feb 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285093: Introduce UTIL_ARG_WITH
8285755: JDK-8285093 changed the default for --with-output-sync
8285919: Remove debug printout from JDK-8285093

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 43a0015: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent
  • d0984df: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

Going to push as commit d7a6e6a.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 1f0e77e: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 4c27fa0: 8231595: [TEST] develop a test case for SuspendThreadList including current thread
  • 8773d46: 8223736: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails due to wrong number of MonitorContendedEntered events
  • 6c6006e: 8224024: java/util/concurrent/BlockingQueue/DrainToFails.java testBounded fails intermittently
  • c90bc80: 8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently
  • 3614fb2: 8222430: Add tests for ElementKind predicates
  • 834e072: 8221098: Run java/net/URL/HandlerLoop.java in othervm mode
  • 88d8eb2: 8170705: sun/net/www/protocol/http/StackTraceTest.java fails intermittently with Invalid Http response
  • a220aaf: 8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp
  • 7d7aa61: 8218133: sun/net/www/protocol/http/ProtocolRedirect.java failed with "java.net.ConnectException"
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/2c47c45f0747e86a3b97384bea48107627ffd040...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2023
@openjdk openjdk bot closed this Feb 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@RealCLanger Pushed as commit d7a6e6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-5b77b574 branch February 15, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants