Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293550: Optionally add get-task-allow entitlement to macos binaries #1739

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Feb 15, 2023

Backport of JDK-8293550


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293550: Optionally add get-task-allow entitlement to macos binaries

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1739/head:pull/1739
$ git checkout pull/1739

Update a local copy of the PR:
$ git checkout pull/1739
$ git pull https://git.openjdk.org/jdk11u-dev pull/1739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1739

View PR using the GUI difftool:
$ git pr show -t 1739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1739.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da6fca4d78465625775f7b384ba752185694f699 8293550: Optionally add get-task-allow entitlement to macos binaries Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 15, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be a clean backport from 17u. Ltgm.

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293550: Optionally add get-task-allow entitlement to macos binaries

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0a91274: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • 6678084: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • b096b9d: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

Going to push as commit 630c80e.
Since your change was applied there have been 11 commits pushed to the master branch:

  • d942151: 8209774: Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java
  • 131084c: 8035787: SourcePositions are wrong for Strings concatenated with '+' operator
  • 1d32290: 8233462: serviceability/tmtools/jstat tests times out with -Xcomp
  • 5c1748a: 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"
  • 22be061: 8226917: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails on jvmti->InterruptThread (JVMTI_ERROR_THREAD_NOT_ALIVE)
  • a3d867b: 8226595: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java still fails due to wrong number of MonitorContendedEntered events
  • 3a2a0f9: 8223463: Replace wildcard address with loopback or local host in tests - part 2
  • 5685e58: 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests
  • 0a91274: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • 6678084: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/d7a6e6ae495a780c6818dd69ae240ac092e41504...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2023
@openjdk openjdk bot closed this Feb 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@RealCLanger Pushed as commit 630c80e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-da6fca4d branch February 16, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants