Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles #1791

Closed
wants to merge 1 commit into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Mar 1, 2023

backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backoport JDK-8262981 is reworked and built a slider and other GUIs and components and manually tested the UI with Accessibility functions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1791/head:pull/1791
$ git checkout pull/1791

Update a local copy of the PR:
$ git checkout pull/1791
$ git pull https://git.openjdk.org/jdk11u-dev pull/1791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1791

View PR using the GUI difftool:
$ git pr show -t 1791

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1791.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6c107fdff289cc553df12ee10b0c8002b84059b2 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 1, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

⚠️ @Autumn808 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8264299
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@Autumn808 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 915ac57: 8302000: [11u] A subtle race condition during jdk11u build
  • 125cf5a: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • de6d2c9: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols
  • 2405ca6: 8299520: TestPrintXML.java output error messages in case compare fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2023
@phohensee
Copy link
Member

Tagged the JBS issue.

@Autumn808
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@Autumn808
Your change (at version fd7fbcc) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 3, 2023

Going to push as commit 8a726af.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 915ac57: 8302000: [11u] A subtle race condition during jdk11u build
  • 125cf5a: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • de6d2c9: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols
  • 2405ca6: 8299520: TestPrintXML.java output error messages in case compare fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2023
@openjdk openjdk bot closed this Mar 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@phohensee @Autumn808 Pushed as commit 8a726af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants