8220093: Change to GCC 8.2 for building on Linux at Oracle

[RealCLanger]

This is a backport of JDK-8220093. The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g.

configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]

vs

configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]

One can then deduct the version of binutils used.

I had to make a few modifications. In toolchain.m4, JDK-8257679 was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8220093: Change to GCC 8.2 for building on Linux at Oracle

Reviewers

• Matthias Baesken (@MBaesken - Reviewer) ⚠️ Review applies to 5c375ac1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1792/head:pull/1792
$ git checkout pull/1792

Update a local copy of the PR:
$ git checkout pull/1792
$ git pull https://git.openjdk.org/jdk11u-dev pull/1792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1792

View PR using the GUI difftool:
$ git pr show -t 1792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1792.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (284fdd82)
• 00: Full (5c375ac1)

[tstuefe]

There is a hunk missing (Tools.gmk 370ff) ?

[RealCLanger]

There is a hunk missing (Tools.gmk 370ff) ?

True. I should have explained my reasoning here: I didn't dare to change the devkit build logic from --enable-gold to --enable-gold=default as we had seen issues with compatibility by that change which makes the build use the gold linker then.

[MBaesken]

looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8220093: Change to GCC 8.2 for building on Linux at Oracle

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[VladimirKempik]

looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change

It's wrong way.

jib-profiles.js is used internally in oracle.

Oracle has their own branch of 11u, and not building from openjdk11u
Therefore jib-profiles.js change should be dropped from the backport as it has no reason to go into openjdk11u

[RealCLanger]

looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change

It's wrong way.

jib-profiles.js is used internally in oracle.

Oracle has their own branch of 11u, and not building from openjdk11u Therefore jib-profiles.js change should be dropped from the backport as it has no reason to go into openjdk11u

I'd say it doesn't matter. As I stated above, it is not relevant in OpenJDK. I can however drop the changes to the file.

[GoeLin]

Why are the tests failing?

[RealCLanger]

Why are the tests failing?

Probably nothing to do with my change - I've retriggered.

[RealCLanger]

Why are the tests failing?

Probably nothing to do with my change - I've retriggered.

OK, still failing tests but this time others. That's all GHA wag.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit b8ac68d.
Since your change was applied there have been 4 commits pushed to the master branch:

• 97809af: 8303937: Corrupted heap dumps due to missing retries for os::write()
• c6f0085: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id
• 939741c: 8293232: Fix race condition in pkcs11 SessionManager
• e80528b: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit b8ac68d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.