New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation #1806
Conversation
👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Hi @Autumn808, why do you make this one a dependent PR on #1804? I think this could go on its own. Just rebase your branch to a master branch where you cherry-pick your commit Autumn808@d896246 on. OTOH, you might just integrate #1804 now since I have it approved. Then merge master into this PR. Cheers |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8263420
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@Autumn808 this pull request can not be integrated into git checkout JDK-8263420
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@Autumn808 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
…peer implementation Reviewed-by: kizune (cherry picked from commit d896246)
@Autumn808 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@Autumn808 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged the JBS issue. |
/integrate |
@Autumn808 |
/sponsor |
Going to push as commit 4b5fdd8.
Your commit was automatically rebased without conflicts. |
@RealCLanger @Autumn808 Pushed as commit 4b5fdd8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1806/head:pull/1806
$ git checkout pull/1806
Update a local copy of the PR:
$ git checkout pull/1806
$ git pull https://git.openjdk.org/jdk11u-dev pull/1806/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1806
View PR using the GUI difftool:
$ git pr show -t 1806
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1806.diff