New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large #49
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backout looks clean.
I also applied it and checked delta between this PR and the commit before 8279219. Affected files look identical apart from opto/split_if.cpp which was modified with as part of "8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination" 22f8e21
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
Going to push as commit 63e4b5c. |
@jerboaa I don't see corresponding backport bug linked to JDK-8292260. |
I believe a backport bug will be created once we merge this back into the master branch. Let's see what happens. If Skara bots fail to do so, we need to create one manually. |
We've only integrated this into the |
@jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record. |
@kevinrushforth OK. Thank you! |
Looks like this is resolved now. Good to know that the Skara bots also operate on branches. |
PR to backout the change of JDK-8279219. I'll change this to the proper backport title once JDK 19 backout is done.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/49/head:pull/49
$ git checkout pull/49
Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk11u pull/49/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 49
View PR using the GUI difftool:
$ git pr show -t 49
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/49.diff