Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large #49

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Aug 12, 2022

PR to backout the change of JDK-8279219. I'll change this to the proper backport title once JDK 19 backout is done.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk11u pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/49.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into jdk11.0.16.1 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks clean.

I also applied it and checked delta between this PR and the commit before 8279219. Affected files look identical apart from opto/split_if.cpp which was modified with as part of "8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination" 22f8e21

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk11.0.16.1 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk11.0.16.1 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
@jerboaa jerboaa changed the title 8292260: Backout [REDO] C2 crash when allocating array of size too large 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Aug 12, 2022
@jerboaa jerboaa changed the title 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Backport 967a28c3d85fdde6d5eb48aa0edd8f7597772469 Aug 12, 2022
@openjdk openjdk bot changed the title Backport 967a28c3d85fdde6d5eb48aa0edd8f7597772469 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 12, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

Going to push as commit 63e4b5c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2022
@openjdk openjdk bot closed this Aug 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@jerboaa Pushed as commit 63e4b5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov
Copy link
Contributor

@jerboaa I don't see corresponding backport bug linked to JDK-8292260.

@RealCLanger
Copy link
Contributor

@jerboaa I don't see corresponding backport bug linked to JDK-8292260.

I believe a backport bug will be created once we merge this back into the master branch. Let's see what happens. If Skara bots fail to do so, we need to create one manually.

@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 15, 2022

We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create one manually for 11.0.16.1.

@kevinrushforth
Copy link
Member

We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1.

@jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record.

@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 15, 2022

@kevinrushforth OK. Thank you!

@RealCLanger
Copy link
Contributor

We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1.

@jerboaa I alerted @erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record.

Looks like this is resolved now. Good to know that the Skara bots also operate on branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
5 participants