Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8279520: SPNEGO has not passed channel binding info into the underlying mechanism #369

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Jul 15, 2022

It's a clean backport of JDK-8279520 to jdk13u.

It's backported for parity with jdk11u.
In addition it should get backported prior to JDK-8279842 to make the test HttpsCB.java pass successfully.

Tested on Linux x64, Windows x64, macOS x64 with the tests' group test/jdk/sun/security/krb5 with no regression.
The included test IgnoreChannelBinding.java passed successfully.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/369/head:pull/369
$ git checkout pull/369

Update a local copy of the PR:
$ git checkout pull/369
$ git pull https://git.openjdk.org/jdk13u-dev pull/369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 369

View PR using the GUI difftool:
$ git pr show -t 369

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/369.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d0f385fd0243c3e38b400f463b8d9727b0a5956 8279520: SPNEGO has not passed channel binding info into the underlying mechanism Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279520: SPNEGO has not passed channel binding info into the underlying mechanism

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

Going to push as commit e93cf85.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 15, 2022
@openjdk openjdk bot closed this Jul 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@omikhaltsova Pushed as commit e93cf85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant