Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8266172: -Wstringop-overflow happens in vmError.cpp #406

Conversation

wkia
Copy link

@wkia wkia commented Sep 16, 2022

Backport JDK-8266172 to 13u
A part of GCC11 compliance.
Applied with a small modification - "VMError::segfault_address" class member field is absent in 15u and 13u, so "VMError::get_segfault_address()" is still used..
No tier1 regressions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266172: -Wstringop-overflow happens in vmError.cpp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/406/head:pull/406
$ git checkout pull/406

Update a local copy of the PR:
$ git checkout pull/406
$ git pull https://git.openjdk.org/jdk13u-dev pull/406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 406

View PR using the GUI difftool:
$ git pr show -t 406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/406.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2022

👋 Welcome back wkia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c97f56cdafe26dfafcfbc6bb42fa5617641c1a59 8266172: -Wstringop-overflow happens in vmError.cpp Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 16, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266172: -Wstringop-overflow happens in vmError.cpp

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2022
@wkia
Copy link
Author

wkia commented Sep 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@wkia
Your change (at version 48b33ce) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 16, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit 7e5b8d3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@yan-too @wkia Pushed as commit 7e5b8d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the backport-c97f56cdafe26dfafcfbc6bb42fa5617641c1a59 branch September 16, 2022 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants