Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8283059: Uninitialized warning in check_code.c with GCC 11.2 #414

Conversation

wkia
Copy link

@wkia wkia commented Sep 30, 2022

Backport JDK-8283059
This is a fix for GCC11's 'maybe-uninitialized' warning

There was a merge conflict at line 3824, because the backport restores the original code "buffer = malloc(length + 1)" removed previously by an intermediate change in upstream. The jdk13 repository still contain this line unchanged, so this is why the merge conflict occurs here. There is no need to apply any changes to this line in the backport.

No tier1 regression.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283059: Uninitialized warning in check_code.c with GCC 11.2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/414/head:pull/414
$ git checkout pull/414

Update a local copy of the PR:
$ git checkout pull/414
$ git pull https://git.openjdk.org/jdk13u-dev pull/414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 414

View PR using the GUI difftool:
$ git pr show -t 414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/414.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2022

👋 Welcome back wkia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8893fad23d1ee6841336b96c34599643edb81ce 8283059: Uninitialized warning in check_code.c with GCC 11.2 Sep 30, 2022
@openjdk
Copy link

openjdk bot commented Sep 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 30, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283059: Uninitialized warning in check_code.c with GCC 11.2

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • c0ce123: 8266171: -Warray-bounds happens in imageioJPEG.c
  • 9b4411a: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • b295289: 8293988: Bump update version for OpenJDK: jdk-13.0.14
  • 68be363: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • a0d9cc2: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2022
@wkia
Copy link
Author

wkia commented Oct 3, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@wkia
Your change (at version bf8630b) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Oct 3, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

Going to push as commit d4280f1.
Since your change was applied there have been 5 commits pushed to the master branch:

  • c0ce123: 8266171: -Warray-bounds happens in imageioJPEG.c
  • 9b4411a: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • b295289: 8293988: Bump update version for OpenJDK: jdk-13.0.14
  • 68be363: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • a0d9cc2: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2022
@openjdk openjdk bot closed this Oct 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@yan-too @wkia Pushed as commit d4280f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants