Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 #436

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 1, 2022

Hi all,
This pull request contains a backport of commit fb6c992f from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.

This pull request replaces this one

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/436/head:pull/436
$ git checkout pull/436

Update a local copy of the PR:
$ git checkout pull/436
$ git pull https://git.openjdk.org/jdk13u-dev pull/436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 436

View PR using the GUI difftool:
$ git pr show -t 436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/436.diff

Sorry, something went wrong.

@mrserb mrserb marked this pull request as ready for review December 1, 2022 10:44
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296957: One more cast in SAFE_SIZE_NEW_ARRAY2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit e159891.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 246c6c3: 8290451: Incorrect result when switching to C2 OSR compilation from C1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb Pushed as commit e159891.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8296957 branch December 1, 2022 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant