Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8279842: HTTPS Channel Binding support for Java GSS/Kerberos #234

Closed
wants to merge 2 commits into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Jul 15, 2022

It's backport of JDK-8279842 to jdk15u.

The original patch applied cleanly (commit 1) but it's required the following corrections (commit 2) similar to jdk11u:

  1. Replacement of instanceof patterns (AbstractDelegateHttpsURLConnection.java, HttpsCB.java) (JEP 375, JDK 15);
  2. Substitute callAs(..) with doAs(..) (HttpsCB.java) (JDK-8275529, JDK 18);
  3. Add import java.security.PrivilegedExceptionAction (HttpsCB.java).

Tested on Linux x64, Windows x64, macOS x64 with the tests' groups: test/jdk/sun/security/krb5 and test/jdk/com/sun/jndi, - with no regression. The included tests HttpsCB.java and LdapCBPropertiesTest.java passed successfully.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • JDK-8284769: HTTPS Channel Binding support for Java GSS/Kerberos (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk15u-dev pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/234.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport de3113b998550021bb502cd6f766036fb8351e7d 8279842: HTTPS Channel Binding support for Java GSS/Kerberos Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279842: HTTPS Channel Binding support for Java GSS/Kerberos

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022
@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

Going to push as commit 0e09ba9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2022
@openjdk openjdk bot closed this Jul 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@omikhaltsova Pushed as commit 0e09ba9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants