This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
8279842: HTTPS Channel Binding support for Java GSS/Kerberos #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's backport of JDK-8279842 to jdk15u.
The original patch applied cleanly (commit 1) but it's required the following corrections (commit 2) similar to jdk11u:
Tested on Linux x64, Windows x64, macOS x64 with the tests' groups:
test/jdk/sun/security/krb5
andtest/jdk/com/sun/jndi
, - with no regression. The included tests HttpsCB.java and LdapCBPropertiesTest.java passed successfully.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/234/head:pull/234
$ git checkout pull/234
Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk15u-dev pull/234/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 234
View PR using the GUI difftool:
$ git pr show -t 234
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/234.diff