8286277: CDS VerifyError when calling clone() on object array

[jankratochvil]

There was a clean accepted backport to OpenJDK-17.

This OpenJDK-15 backport is not clean as the original commit errors on OpenJDK-15 with:

TEST RESULT: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries

as OpenJDK-15 is missing:

• JDK-8263412: ClassFileInstaller can't be used by classes outside of default package

Issues

• JDK-8286277: CDS VerifyError when calling clone() on object array

I am not yet an Author - I do not have JBS account.
There are 3 new testcases and the first 2 ones to be tested require the testsuite to be run with TEST="hotspot_cds tier1".

• runtime/cds/appcds/VerifyObjArrayCloneTest.java
• runtime/cds/appcds/dynamicArchive/VerifyObjArrayCloneTest.java
• runtime/verifier/InvokeClone.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286277: CDS VerifyError when calling clone() on object array

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.org/jdk15u-dev pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/236.diff

[bridgekeeper]

👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (32da9869)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286277: CDS VerifyError when calling clone() on object array

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• f94a924: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
• 0e09ba9: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• bd5c18f: 8262134: compiler/uncommontrap/TestDeoptOOM.java failed with "guarantee(false) failed: wrong number of expression stack elements during deopt"
• 8deef7f: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 32da986) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit ce091ab.
Since your change was applied there have been 4 commits pushed to the master branch:

• f94a924: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
• 0e09ba9: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• bd5c18f: 8262134: compiler/uncommontrap/TestDeoptOOM.java failed with "guarantee(false) failed: wrong number of expression stack elements during deopt"
• 8deef7f: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @jankratochvil Pushed as commit ce091ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.