Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8283277: ISO 4217 Amendment 171 Update #253

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Aug 15, 2022

Regular (someway belated) change for every release train. Not formally clean backport: different lists of bugs in the tests. All currency, resources tests run fine.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/253/head:pull/253
$ git checkout pull/253

Update a local copy of the PR:
$ git checkout pull/253
$ git pull https://git.openjdk.org/jdk15u-dev pull/253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 253

View PR using the GUI difftool:
$ git pr show -t 253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/253.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c4dc58e12e197562dce90c0027aa74c29047cea6 8283277: ISO 4217 Amendment 171 Update Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 15, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283277: ISO 4217 Amendment 171 Update

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b176776: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle
  • ed0200a: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Aug 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

Going to push as commit 1e3901d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • b176776: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle
  • ed0200a: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2022
@openjdk openjdk bot closed this Aug 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@yan-too Pushed as commit 1e3901d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8283277 branch August 16, 2022 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants