Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8290451: Incorrect result when switching to C2 OSR compilation from C1 #309

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 1, 2022

Clean backport of a C2 change for parity with LTS releases. Compiler tests do pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290451: Incorrect result when switching to C2 OSR compilation from C1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.org/jdk15u-dev pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/309.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport afa5d4ced38b7f3752932c28af96d8fc600d1df7 8290451: Incorrect result when switching to C2 OSR compilation from C1 Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290451: Incorrect result when switching to C2 OSR compilation from C1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ea36dfe: 8296496: Overzealous check in sizecalc.h prevents large memory allocation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Dec 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 8dbca0d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7750a23: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
  • ea36dfe: 8296496: Overzealous check in sizecalc.h prevents large memory allocation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@yan-too Pushed as commit 8dbca0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8290451 branch December 1, 2022 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant