Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() #1021

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 3, 2023

I backport this for parity with 17.0.7-oracle.

Locally, the patch applied clean, but the /backport command did not manage to apply this.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1021/head:pull/1021
$ git checkout pull/1021

Update a local copy of the PR:
$ git checkout pull/1021
$ git pull https://git.openjdk.org/jdk17u-dev pull/1021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1021

View PR using the GUI difftool:
$ git pr show -t 1021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1021.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5efa2afe268e3171f54d8488ef69bf67059bd7f 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

Going to push as commit 013709f.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 6469c30: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
  • 26f0348: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • d3c4a14: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs
  • 3762bd0: 8270476: Make floating-point test infrastructure more lambda and method reference friendly
  • bd58dd8: 8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup
  • 1f4fc33: 8275843: Random crashes while the UI code is executed
  • 298fef7: 8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
  • a395cf7: 8008243: Zero: Implement fast bytecodes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2023
@openjdk openjdk bot closed this Jan 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2023
@GoeLin GoeLin deleted the goetz_backport_8294538 branch January 4, 2023 09:37
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@GoeLin Pushed as commit 013709f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant