Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error #1061

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 12, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1061/head:pull/1061
$ git checkout pull/1061

Update a local copy of the PR:
$ git checkout pull/1061
$ git pull https://git.openjdk.org/jdk17u-dev pull/1061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1061

View PR using the GUI difftool:
$ git pr show -t 1061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1061.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1e6f26160e811b8d6f44108899422a62c0be388 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit e490cad.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 1032a0f: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • 4780e49: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit
  • 63da2b0: 8295413: com/sun/jdi/EATests.java fails with compiler flag -XX:+StressReflectiveCode
  • 6e544c2: 8299520: TestPrintXML.java output error messages in case compare fails
  • 772f90a: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 08e30d0: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • f8a8417: 8299388: java/util/regex/NegativeArraySize.java fails on Alpine and sometimes Windows
  • ead3081: 8296619: Upgrade jQuery to 3.6.1
  • 0db4add: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • eceb480: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/520ae87929c3c4443243a3abfcd90e2c0cf933c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@MBaesken Pushed as commit e490cad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant