Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev #1085

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 19, 2023

Simple version change for ea builds in -dev.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1085/head:pull/1085
$ git checkout pull/1085

Update a local copy of the PR:
$ git checkout pull/1085
$ git pull https://git.openjdk.org/jdk17u-dev pull/1085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1085

View PR using the GUI difftool:
$ git pr show -t 1085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1085.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@RealCLanger
Copy link
Contributor

You will probably need to fix the title of this PR.

@GoeLin GoeLin changed the title 8300642: Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev 8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 19, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

Going to push as commit b3e16fc.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023
@openjdk openjdk bot closed this Jan 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@GoeLin Pushed as commit b3e16fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8300642 branch January 19, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants