Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs #1104

Closed
wants to merge 1 commit into from
Closed

8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs #1104

wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Jan 24, 2023 •
edited by openjdk bot

Backport https://bugs.openjdk.org/browse/JDK-8299497

Simple clean backport.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1104/head:pull/1104
$ git checkout pull/1104

Update a local copy of the PR:
$ git checkout pull/1104
$ git pull https://git.openjdk.org/jdk17u-dev pull/1104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1104

View PR using the GUI difftool:
$ git pr show -t 1104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1104.diff

@Rudometov
8299497: Usage of constructors of primitive wrapper classes should be…
ead8c22 
… avoided in java.desktop API docs

Reviewed-by: serb, prr
(cherry picked from commit b5ee3d1f2abf5af86438ac4c9e3da3cc026dffd3)
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5ee3d1f2abf5af86438ac4c9e3da3cc026dffd3 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 24, 2023 •
edited

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism
  • 48d5259: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2023

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@Rudometov
Your change (at version ead8c22) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit 0720b24.
Since your change was applied there have been 11 commits pushed to the master branch:

  • a34f2d3: 8300773: Address the inconsistency between the constant array and pool size
  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/b3e16fc287b6656e0227b30e698f544c3998843d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@phohensee @Rudometov Pushed as commit 0720b24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
2 participants
@Rudometov @phohensee