Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276086: Increase size of metaspace mappings #1113

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 25, 2023

Downport as a prereq for JDK-8294677 "chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1113/head:pull/1113
$ git checkout pull/1113

Update a local copy of the PR:
$ git checkout pull/1113
$ git pull https://git.openjdk.org/jdk17u-dev pull/1113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1113

View PR using the GUI difftool:
$ git pr show -t 1113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1113.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e89b2c040c68aebf6a099602bc0e04f963e89c84 8276086: Increase size of metaspace mappings Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276086: Increase size of metaspace mappings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Jan 27, 2023

Test errors unrelated. SAP nightlies went through.

@tstuefe
Copy link
Member Author

tstuefe commented Jan 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit b22bce8.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 1a38e26: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros
  • 4e5f5de: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • 5fd778b: 8300692: GCC 12 reports some compiler warnings in bundled freetype
  • 651ba86: 8286694: Incorrect argument processing in java launcher
  • f6ad61c: 8275582: Don't purge metaspace mapping lists
  • b7d83f4: 8293466: libjsig should ignore non-modifying sigaction calls
  • fae1628: 8293493: Signal Handlers printout should show signal block state

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@tstuefe Pushed as commit b22bce8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant