Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245654: Add Certigna Root CA #1185

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 22, 2023

I backport this for parity with 17.0.7-oracle.

The certificate is located in a different directory in 17.

I had to adapt the hash in test VerifyCACerts.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1185/head:pull/1185
$ git checkout pull/1185

Update a local copy of the PR:
$ git checkout pull/1185
$ git pull https://git.openjdk.org/jdk17u-dev pull/1185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1185

View PR using the GUI difftool:
$ git pr show -t 1185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1185.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 91607436b79126ccb999deaf38a98209dbfe6ec1 8276058: Some swing test fails on specific CI macos system Feb 22, 2023
@openjdk
Copy link

openjdk bot commented Feb 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 22, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2023

Webrevs

@GoeLin GoeLin changed the title 8276058: Some swing test fails on specific CI macos system Backport 8c87a67419b91f254ed7e4dd8ac8d294b8c Feb 22, 2023
@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 22, 2023
@GoeLin GoeLin changed the title Backport 8c87a67419b91f254ed7e4dd8ac8d294b8c Backport 8c87a67419b91f254ed7e4dd8ac8d294b8c4735e Feb 22, 2023
@openjdk openjdk bot changed the title Backport 8c87a67419b91f254ed7e4dd8ac8d294b8c4735e 8245654: Add Certigna Root CA Feb 22, 2023
@openjdk
Copy link

openjdk bot commented Feb 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2023
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245654: Add Certigna Root CA

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

Going to push as commit c8ee076.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a0cda28: 8294902: Undefined Behavior in C2 regalloc with null references
  • 3c1e03b: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • bf4e659: 8272702: Resolving URI relative path with no / may lead to incorrect toString

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2023
@openjdk openjdk bot closed this Feb 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@GoeLin Pushed as commit c8ee076.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8245654 branch February 24, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants