Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError #1213

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 21, 2023

Hi all,
This pull request contains a backport of commit 78b1686c from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R.
Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1213/head:pull/1213
$ git checkout pull/1213

Update a local copy of the PR:
$ git checkout pull/1213
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1213

View PR using the GUI difftool:
$ git pr show -t 1213

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1213.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 78b1686c150aeaa29c5d969b70c9c42c872246a2 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 21, 2023
@mrserb mrserb marked this pull request as ready for review March 23, 2023 06:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean except for copyright date conflict in Win32ShellFolder2.java.

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 04e337c: 8303575: adjust Xen handling on Linux aarch64
  • 8a2425d: 8300042: Improve CPU related JFR events descriptions
  • 3b64bde: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2023
@mrserb
Copy link
Member Author

mrserb commented Mar 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2023

Going to push as commit 6d61fc1.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 04e337c: 8303575: adjust Xen handling on Linux aarch64
  • 8a2425d: 8300042: Improve CPU related JFR events descriptions
  • 3b64bde: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2023
@openjdk openjdk bot closed this Mar 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2023
@openjdk
Copy link

openjdk bot commented Mar 24, 2023

@mrserb Pushed as commit 6d61fc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-78b1686c branch March 24, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants