New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError #1213
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean except for copyright date conflict in Win32ShellFolder2.java.
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6d61fc1.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 78b1686c from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1213/head:pull/1213
$ git checkout pull/1213
Update a local copy of the PR:
$ git checkout pull/1213
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1213/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1213
View PR using the GUI difftool:
$ git pr show -t 1213
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1213.diff