Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293798: Fix test bugs due to incompatibility with -XX:+AlwaysIncrementalInline #2376

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 6, 2024

I backport this for parity with 17.0.12-oracle.

I had to resolve both files. A third test is not in 17, omitted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293798 needs maintainer approval

Issue

  • JDK-8293798: Fix test bugs due to incompatibility with -XX:+AlwaysIncrementalInline (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2376/head:pull/2376
$ git checkout pull/2376

Update a local copy of the PR:
$ git checkout pull/2376
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2376

View PR using the GUI difftool:
$ git pr show -t 2376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2376.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 12e3510f63b46db1559d240a331d66f15fe91363 8293798: Fix test bugs due to incompatibility with -XX:+AlwaysIncrementalInline Apr 6, 2024
@openjdk
Copy link

openjdk bot commented Apr 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 6, 2024
@GoeLin GoeLin marked this pull request as draft April 6, 2024 19:58
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 6, 2024

We probably should backport "8254108: ciReplay: Support incremental inlining"

@GoeLin GoeLin closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant