Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible #467

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 14, 2022

Hi!

Here is a backport of 8287894 that fixes reproducible debug build for Windows. The original patch applied cleanly.

Verification (Windows10/MSVS2019): bash ./configure --with-boot-jdk=c:/work/boot-jdk/jdk-18 --with-debug-level=fastdebug --with-hotspot-build-time="6/7/2022 2:35pm" --with-extra-cflags="/experimental:deterministic"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287894: Use fixed timestamp as an alternative of DATE macro in jdk.jdi to make Windows build reproducible

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/467/head:pull/467
$ git checkout pull/467

Update a local copy of the PR:
$ git checkout pull/467
$ git pull https://git.openjdk.org/jdk17u-dev pull/467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 467

View PR using the GUI difftool:
$ git pr show -t 467

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/467.diff

…dk.jdi to make Windows build reproducible

Reviewed-by: erikj, ihse
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9d46f3413ef64c87520509fd70ac42629fbce91 8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 321 new commits pushed to the master branch:

  • cb415a1: 8284686: Interval of < 1 ms disables ExecutionSample events
  • f8d3d42: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • dd7280f: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]
  • 1963985: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • 8563eec: 8287663: Add a regression test for JDK-8287073
  • cb88133: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 292d90d: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
  • a081e4a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • aa3d2f7: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • 66cdd6e: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • ... and 311 more: https://git.openjdk.org/jdk17u-dev/compare/5159ffd487d858f33eb50f0bb8f2bfb28fcce5ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant