Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512 #469

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 15, 2022

I backport this for parity with 17.0.5-oracle.

I had to resolve because "8275047: Optimize existing fill stubs for AVX-512 target"
which renames fill**_avx() to fill**() is not in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/469/head:pull/469
$ git checkout pull/469

Update a local copy of the PR:
$ git checkout pull/469
$ git pull https://git.openjdk.org/jdk17u-dev pull/469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 469

View PR using the GUI difftool:
$ git pr show -t 469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/469.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd8709e8e05897d131afba221970c0866b3d126d 8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512 Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the new fill functions are only used inside MacroAssembler. LGTM.

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

Going to push as commit 50c0080.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 7975c0a: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
  • 6f4c270: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
  • 4b25717: 8285398: Cache the results of constraint checks
  • e4d1d62: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
  • 4dd34b7: 8286429: jpackageapplauncher build fails intermittently in Tier[45]
  • 29579f4: 8273115: CountedLoopEndNode::stride_con crash in debug build with -XX:+TraceLoopOpts
  • ed71536: 8282640: Create a test for JDK-4740761
  • 1f84775: 8281569: Create tests for Frame.setMinimumSize() method
  • 66ccd22: 8282538: PKCS11 tests fail on CentOS Stream 9

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2022
@openjdk openjdk bot closed this Jun 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin Pushed as commit 50c0080.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8284883 branch June 21, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants