Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283457: [macos] libpng build failures with Xcode13.3 #492

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 21, 2022

Hi all,
This pull request contains a backport of commit 33eb89df from the openjdk/jdk repository.
The commit being backported was authored by Phil Race on 22 Mar 2022 and was reviewed by Erik Joelsson.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283457: [macos] libpng build failures with Xcode13.3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/492/head:pull/492
$ git checkout pull/492

Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk17u-dev pull/492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 492

View PR using the GUI difftool:
$ git pr show -t 492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/492.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 33eb89dfeb4a43e1ad2c3dd657ec3b6ee7abbb3a 8283457: [macos] libpng build failures with Xcode13.3 Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283457: [macos] libpng build failures with Xcode13.3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@mrserb mrserb marked this pull request as ready for review June 21, 2022 21:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 22, 2022

I assume the Pre-submit build problems are unrelated to this change.

@mrserb
Copy link
Member Author

mrserb commented Jun 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

Going to push as commit a2be28d.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a411085: 8285081: Improve XPath operators count accuracy
  • 4403118: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5
  • b7d808e: 8284367: JQuery UI upgrade from 1.12.1 to 1.13.1
  • c1e544f: 8286638: C2: CmpU needs to do more precise over/underflow analysis
  • b91c492: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • e0750eb: 8265360: several compiler/whitebox tests fail with "private compiler.whitebox.SimpleTestCaseHelper(int) must be compiled"
  • 9f57018: 8274597: Some of the dnd tests time out and fail intermittently
  • d798aa2: 8284521: Write an automated regression test for RFE 4371575
  • 3b8f43e: 8282046: Create a regression test for JDK-8000326
  • f5e1c3f: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2022
@openjdk openjdk bot closed this Jun 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@mrserb Pushed as commit a2be28d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants