Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289197: [17u] Push of backport of 8286177 did not remove assertion #509

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 27, 2022

When I pushed 8286177, I missed removing the assertion that was
addressed by that change. This is corrected by this follow up.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289197: [17u] Push of backport of 8286177 did not remove assertion

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/509/head:pull/509
$ git checkout pull/509

Update a local copy of the PR:
$ git checkout pull/509
$ git pull https://git.openjdk.org/jdk17u-dev pull/509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 509

View PR using the GUI difftool:
$ git pr show -t 509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/509.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How could that miss happen? Why did GHA for the JDK-8286177 not show this?

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289197: [17u] Push of backport of 8286177 did not remove assertion

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bbe8c34: 8287366: Improve test failure reporting in GHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2022

Good question, but they are green: https://github.com/openjdk/jdk17u-dev/pull/495/checks
Maybe GitHub resolved the dependent PR wrongly?
My original backport was correct: GoeLin@594456f

@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit 0ea78e5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bbe8c34: 8287366: Improve test failure reporting in GHA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@GoeLin Pushed as commit 0ea78e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8289197 branch August 7, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants