8286277: CDS VerifyError when calling clone() on object array

[jankratochvil]

This bug has been faced by a customer and this backport does work for them.

Issues

• JDK-8286277: CDS VerifyError when calling clone() on object array

I am not yet an Author - I do not have JBS account.
The testcase works after backporting:

   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg/runtime/cds/appcds/VerifyObjArrayCloneTest.java
                                                         1     1     0     0
   jtreg:test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/VerifyObjArrayCloneTest.java
                                                         1     1     0     0

And there is no regression:

->> jtreg:test/hotspot/jtreg:tier1                     1817  1810     7     0 <<
+>> jtreg:test/hotspot/jtreg:tier1                     1818  1811     7     0 <<

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286277: CDS VerifyError when calling clone() on object array

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/519/head:pull/519
$ git checkout pull/519

Update a local copy of the PR:
$ git checkout pull/519
$ git pull https://git.openjdk.org/jdk17u-dev pull/519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 519

View PR using the GUI difftool:
$ git pr show -t 519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/519.diff

[bridgekeeper]

👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jankratochvil]

OCA is signed by my employer Azul Systems.

[mlbridge]

Webrevs

• 01: Full - Incremental (ef386747)
• 00: Full (990bdde0)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jankratochvil the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jdk8286277
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286277: CDS VerifyError when calling clone() on object array

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 01217e1: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
• a5e273d: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
• 1305516: 8269039: Disable SHA-1 Signed JARs
• 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
• a6c02bd: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
• d3354af: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
• f73037d: 8286625: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
• 7f40f16: 8278067: Make HttpURLConnection default keep alive timeout configurable
• 774213f: 8256844: Make NMT late-initializable
• 437c634: 8281181: Do not use CPU Shares to compute active processor count

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[GoeLin]

Please enable Pre-submit tests!

[jankratochvil]

Pre-submit tests are done, sorry for not checking it earlier.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version ef38674) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 363a8ff.
Since your change was applied there have been 10 commits pushed to the master branch:

• 01217e1: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
• a5e273d: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
• 1305516: 8269039: Disable SHA-1 Signed JARs
• 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
• a6c02bd: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
• d3354af: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
• f73037d: 8286625: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
• 7f40f16: 8278067: Make HttpURLConnection default keep alive timeout configurable
• 774213f: 8256844: Make NMT late-initializable
• 437c634: 8281181: Do not use CPU Shares to compute active processor count

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @jankratochvil Pushed as commit 363a8ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.