Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS #520

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Jul 1, 2022

Hi all,

This pull request contains a backport of commit ad128284 from the openjdk/jdk repository.

The commit being backported was authored by Aleksandr Veselov on 20 Dec 2021 and was reviewed by Anton Tarasov and Alexander Zuev. I'd like to backport this for Oracle JDK17 parity.

A few notes on testing. There are no tests in the patch. The JBS bug says only this in terms of reproducing the issue:

When an app is displayed on a secondary monitor whose vertical resolution differs from the primary monitor, accessibility outline frame gets misplaced while navigating UI elements.
This can be easily reproduced with SwingSet2, for instance.

I built and ran https://github.com/xjrga/swingset2 on macOS 11.5.2 (20G95) with an external display with a deliberately different resolution from the mac's internal panel, but I could not reproduce the original issue.

The patch itself backports clean. I ran swingset2 afterwards and noticed no obvious difference (but all the various widgets worked fine)

If anyone wants to suggest any further specific manual tests I could perform to reproduce the original issue or validate the fix I'm happy to try them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/520/head:pull/520
$ git checkout pull/520

Update a local copy of the PR:
$ git checkout pull/520
$ git pull https://git.openjdk.org/jdk17u-dev pull/520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 520

View PR using the GUI difftool:
$ git pr show -t 520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/520.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad1282842c5eefdad151afe6f4db97a09d643546 8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS Jul 1, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jul 5, 2022

These are really hard to test.
Instead of omitting the backports because the testing is too complicated, we should
be a bit more relaxed here. So I think this is fine.

@jmtd
Copy link
Author

jmtd commented Jul 5, 2022

/clean

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@jmtd Only OpenJDK Committers can use the /clean command

@jmtd
Copy link
Author

jmtd commented Jul 5, 2022

Oh, ok!

@GoeLin are you able to mark the PR as reviewed for the bots? I'm not sure how to do that. I'll issue integrate now:

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@jmtd This pull request has not yet been marked as ready for integration.

@GoeLin
Copy link
Member

GoeLin commented Jul 5, 2022

/clean

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@GoeLin Can only mark backport pull requests, with an original hash, as clean

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
... this is not so simple :) You should become author in jdk-updates!

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • a5e273d: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
  • 1305516: 8269039: Disable SHA-1 Signed JARs
  • 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • a6c02bd: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
  • d3354af: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
  • f73037d: 8286625: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
  • 7f40f16: 8278067: Make HttpURLConnection default keep alive timeout configurable
  • 774213f: 8256844: Make NMT late-initializable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2022
@GoeLin
Copy link
Member

GoeLin commented Jul 5, 2022

Can you integrate again please?

@jmtd
Copy link
Author

jmtd commented Jul 6, 2022

/integrate

... this is not so simple :) You should become author in jdk-updates!

Yes good point, I forgot I hadn't applied for that (I did so for 8u). Thanks for the hint!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@jmtd
Your change (at version a9adf2e) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

Going to push as commit a4642ae.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 05b9400: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes
  • 25b7596: 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS
  • db2010b: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
  • 3ad1445: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
  • ab90ac3: 8287735: Provide separate event category for dll operations
  • 363a8ff: 8286277: CDS VerifyError when calling clone() on object array
  • 01217e1: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
  • a5e273d: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
  • 1305516: 8269039: Disable SHA-1 Signed JARs
  • 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/437c634b61c277e6af6efd243399178dd44d7126...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2022
@openjdk openjdk bot closed this Jul 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@RealCLanger @jmtd Pushed as commit a4642ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants