New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS #520
Conversation
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
These are really hard to test. |
/clean |
@jmtd Only OpenJDK Committers can use the |
Oh, ok! @GoeLin are you able to mark the PR as reviewed for the bots? I'm not sure how to do that. I'll issue integrate now: /integrate |
@jmtd This pull request has not yet been marked as ready for integration. |
/clean |
@GoeLin Can only mark backport pull requests, with an original hash, as clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
... this is not so simple :) You should become author in jdk-updates!
@jmtd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Can you integrate again please? |
/integrate
Yes good point, I forgot I hadn't applied for that (I did so for 8u). Thanks for the hint! |
/sponsor |
Going to push as commit a4642ae.
Your commit was automatically rebased without conflicts. |
@RealCLanger @jmtd Pushed as commit a4642ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit ad128284 from the openjdk/jdk repository.
The commit being backported was authored by Aleksandr Veselov on 20 Dec 2021 and was reviewed by Anton Tarasov and Alexander Zuev. I'd like to backport this for Oracle JDK17 parity.
A few notes on testing. There are no tests in the patch. The JBS bug says only this in terms of reproducing the issue:
I built and ran https://github.com/xjrga/swingset2 on macOS 11.5.2 (20G95) with an external display with a deliberately different resolution from the mac's internal panel, but I could not reproduce the original issue.
The patch itself backports clean. I ran swingset2 afterwards and noticed no obvious difference (but all the various widgets worked fine)
If anyone wants to suggest any further specific manual tests I could perform to reproduce the original issue or validate the fix I'm happy to try them.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/520/head:pull/520
$ git checkout pull/520
Update a local copy of the PR:
$ git checkout pull/520
$ git pull https://git.openjdk.org/jdk17u-dev pull/520/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 520
View PR using the GUI difftool:
$ git pr show -t 520
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/520.diff