Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS #524

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 4, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/524/head:pull/524
$ git checkout pull/524

Update a local copy of the PR:
$ git checkout pull/524
$ git pull https://git.openjdk.org/jdk17u-dev pull/524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 524

View PR using the GUI difftool:
$ git pr show -t 524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/524.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 590fa9d8d75b4cf401fe5a1556f4f0b7145a77ab 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

Going to push as commit 25b7596.
Since your change was applied there have been 8 commits pushed to the master branch:

  • db2010b: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
  • 3ad1445: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
  • ab90ac3: 8287735: Provide separate event category for dll operations
  • 363a8ff: 8286277: CDS VerifyError when calling clone() on object array
  • 01217e1: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
  • a5e273d: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
  • 1305516: 8269039: Disable SHA-1 Signed JARs
  • 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2022
@openjdk openjdk bot closed this Jul 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@GoeLin Pushed as commit 25b7596.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant