Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060 #536

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 7, 2022

Clean backport of JDK-8289856. Avoids undefined behavior.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/536/head:pull/536
$ git checkout pull/536

Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jdk17u-dev pull/536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 536

View PR using the GUI difftool:
$ git pr show -t 536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/536.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e05b2f2c3b9b0276099766bc38a55ff835c989e1 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060 Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 292e6bb: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 011b96c: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 882b5f5: 8287896: PropertiesTest.sh fail on msys2
  • 2e21c87: 8287724: Fix various issues with msys2
  • a391032: 8286573: Remove the unnecessary method Attr#attribTopLevel and its usage
  • 00074c0: 8287895: Some langtools tests fail on msys2
  • 204e67a: 8280863: Update build README to reflect that MSYS2 is supported
  • e642821: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • 0263aba: 8254318: Remove .hgtags
  • ad7fab5: 8289799: Build warning in methodData.cpp memset zero-length parameter

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2022
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review July 12, 2022 15:07
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit 48d1d41.
Since your change was applied there have been 12 commits pushed to the master branch:

  • ccc4732: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • a8e7d8f: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...
  • 292e6bb: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 011b96c: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 882b5f5: 8287896: PropertiesTest.sh fail on msys2
  • 2e21c87: 8287724: Fix various issues with msys2
  • a391032: 8286573: Remove the unnecessary method Attr#attribTopLevel and its usage
  • 00074c0: 8287895: Some langtools tests fail on msys2
  • 204e67a: 8280863: Update build README to reflect that MSYS2 is supported
  • e642821: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/a4642ae2021f2e60ed5ec49a69077ed0a2c6dbcd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@TheRealMDoerr Pushed as commit 48d1d41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8289856_PPC64_C2_init branch July 14, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant