Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287896: PropertiesTest.sh fail on msys2 #542

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 9, 2022

Clean backport of JDK-8287896: PropertiesTest.sh fail on msys2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/542/head:pull/542
$ git checkout pull/542

Update a local copy of the PR:
$ git checkout pull/542
$ git pull https://git.openjdk.org/jdk17u-dev pull/542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 542

View PR using the GUI difftool:
$ git pr show -t 542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/542.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f1dd559e20342b892d0c1ed0314e5bba451bc5d3 8287896: PropertiesTest.sh fail on msys2 Jul 9, 2022
@openjdk
Copy link

openjdk bot commented Jul 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 9, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287896: PropertiesTest.sh fail on msys2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e642821: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • 0263aba: 8254318: Remove .hgtags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Jul 11, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@gdams
Your change (at version cb35ea3) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit 882b5f5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 2e21c87: 8287724: Fix various issues with msys2
  • a391032: 8286573: Remove the unnecessary method Attr#attribTopLevel and its usage
  • 00074c0: 8287895: Some langtools tests fail on msys2
  • 204e67a: 8280863: Update build README to reflect that MSYS2 is supported
  • e642821: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • 0263aba: 8254318: Remove .hgtags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@RealCLanger @gdams Pushed as commit 882b5f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the mysys_props branch July 11, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants