New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280233: Temporarily disable Unix domain sockets in Windows PipeImpl #548
Conversation
Reviewed-by: alanb
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@apavlyutkin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
/integrate |
@apavlyutkin |
/sponsor |
Going to push as commit bd77663.
Your commit was automatically rebased without conflicts. |
@yan-too @apavlyutkin Pushed as commit bd77663. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi!
Here is a backport that disables using of Unix domain socket in Pipe implementation for Windows and switches it back to TCP socket on the loopback. That fixes occasional hangings caused by an error in Winsock2 library. The original patch is applied cleanly.
Verification (Microsoft Windows 10 Pro Build 19044): WSARecvHanger.java
Regression (Microsoft Windows 10 Pro Build 19044): test\jdk\java\nio\channels
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/548/head:pull/548
$ git checkout pull/548
Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.org/jdk17u-dev pull/548/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 548
View PR using the GUI difftool:
$ git pr show -t 548
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/548.diff