Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280233: Temporarily disable Unix domain sockets in Windows PipeImpl #548

Closed
wants to merge 2 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jul 13, 2022

Hi!

Here is a backport that disables using of Unix domain socket in Pipe implementation for Windows and switches it back to TCP socket on the loopback. That fixes occasional hangings caused by an error in Winsock2 library. The original patch is applied cleanly.

Verification (Microsoft Windows 10 Pro Build 19044): WSARecvHanger.java
Regression (Microsoft Windows 10 Pro Build 19044): test\jdk\java\nio\channels


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/548/head:pull/548
$ git checkout pull/548

Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.org/jdk17u-dev pull/548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 548

View PR using the GUI difftool:
$ git pr show -t 548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/548.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03680bea1cca1113ea23a1eb7a413b93dd73c381 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl Jul 13, 2022
@openjdk
Copy link

openjdk bot commented Jul 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

⚠️ @apavlyutkin the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8280233
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2022

Webrevs

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@apavlyutkin
Your change (at version 881dcce) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Jul 19, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit bd77663.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@yan-too @apavlyutkin Pushed as commit bd77663.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants