Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288499: Restore cancel-in-progress in GHA #557

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 17, 2022

clean backport of JDK-8288499: Restore cancel-in-progress in GHA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/557/head:pull/557
$ git checkout pull/557

Update a local copy of the PR:
$ git checkout pull/557
$ git pull https://git.openjdk.org/jdk17u-dev pull/557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 557

View PR using the GUI difftool:
$ git pr show -t 557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/557.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cb5ef3da1904e6639130c601db9644895807b4d6 8288499: Restore cancel-in-progress in GHA Jul 17, 2022
@openjdk
Copy link

openjdk bot commented Jul 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 17, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288499: Restore cancel-in-progress in GHA

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • fc6fa1c: 8284014: Menu items with submenus in JPopupMenu are not spoken on macOS
  • d3b1956: 8282407: Missing ')' in MacResources.properties
  • 100c802: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null]
  • 4bab0eb: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • d755049: 8288003: log events for os::dll_unload

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2022

Webrevs

@RealCLanger
Copy link
Contributor

GHA failures look unrelated.

@gdams
Copy link
Member Author

gdams commented Jul 18, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@gdams
Your change (at version a42a6b2) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

Going to push as commit bebb612.
Since your change was applied there have been 5 commits pushed to the master branch:

  • fc6fa1c: 8284014: Menu items with submenus in JPopupMenu are not spoken on macOS
  • d3b1956: 8282407: Missing ')' in MacResources.properties
  • 100c802: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null]
  • 4bab0eb: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • d755049: 8288003: log events for os::dll_unload

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2022
@openjdk openjdk bot closed this Jul 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@RealCLanger @gdams Pushed as commit bebb612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the cancel branch July 18, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants