8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

[GoeLin]

I backport this for parity with 17.0.5-oracle.

The localization file "de" patched by the original change is not in 17.
It was added in "8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10"
I had a look at backporting that change, too. I think the localization updates are
a nice to have for the LTS. But it is a big change and does not apply well. Each new/removed entry would
have to be checked. So I decided not to do it.
Instead, I inlcude the de file for jpackage in this change, along with the two
new Strings. This file matches the jpackage in 17 as there were no other addions to
the ja and zh files between 17 and 8283805.

I had to adapt the copyright in the ja and zh files.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/565/head:pull/565
$ git checkout pull/565

Update a local copy of the PR:
$ git checkout pull/565
$ git pull https://git.openjdk.org/jdk17u-dev pull/565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 565

View PR using the GUI difftool:
$ git pr show -t 565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/565.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (31904d3f)
• 00: Full (0e51d961)

[openjdk-notifier]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[MBaesken]

Looks okay to me thanks for backporting.
Just wondering why the german (_de) properties files contains english texts for the new entries like ERR_MacAppStoreRuntimeBinExists.
Shouldn't this be adjusted most (all?) of the other texts is in german so it looks a little strange to me and for the new properties we get the same like we would get with the english main properties file?

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 31853fe: Merge
• c53d022: 8284370: Improve zlib usage
• 567bc2e: 8272243: Improve DER parsing
• 860464e: 8281866: Enhance MethodHandle invocations
• 9dcec4d: 8285407: Improve Xalan supports
• d95c921: 8283190: Improve MIDI processing
• 8be0fc0: 8281859: Improve class compilation
• a19a716: 8272249: Better properties of loaded Properties
• b0059e1: 8277608: Address IP Addressing
• bd77663: 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

You are right. It seems the developer adds them in english to all the files, and then eventually they are translated by an expert.
Should I just translate the german one? I'll fail for ja and zh, though :)

[GoeLin]

/integrate

[openjdk]

Going to push as commit 6a4b622.
Since your change was applied there have been 19 commits pushed to the master branch:

• c3aa29f: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
• 00f2b3f: 8281988: Create a regression test for JDK-4618767
• 3a57cc6: 8281745: Create a regression test for JDK-4514331
• c2f6e52: 8281535: Create a regression test for JDK-4670051
• dec16ad: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0
• 89d2c89: 8278311: Debian packaging doesn't work
• 75b7aed: 8276837: [macos]: Error when signing the additional launcher
• 1ee3e05: 8271344: Windows product version issue
• c929865: 8290000: Bump macOS GitHub actions to macOS 11
• 31853fe: Merge
• ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/02215ff8f6f3402fe66315d7e5e9648dea13219d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 6a4b622.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.