Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290417: CDS cannot archive lamda proxy with useImplMethodHandle #575

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented Jul 21, 2022

This bug has been faced by a customer and this backport does work for them.
I am not yet an Author - I do not have JBS account.
I have run the testsuite on Linux x86_64 and there is no change of the results. Two new testcases are added and they are both Passing. The testcases are still Passing after backporting them to 17u-dev.

+Passed: runtime/cds/appcds/LambdaWithUseImplMethodHandle.java
+Passed: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290417: CDS cannot archive lamda proxy with useImplMethodHandle

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/575/head:pull/575
$ git checkout pull/575

Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jdk17u-dev pull/575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 575

View PR using the GUI difftool:
$ git pr show -t 575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/575.diff

Backport-of: 4dc421caa02caedd7061ede6a5ec44dbb6ec738e
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4dc421caa02caedd7061ede6a5ec44dbb6ec738e 8290417: CDS cannot archive lamda proxy with useImplMethodHandle Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290417: CDS cannot archive lamda proxy with useImplMethodHandle

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 2e12c18: 8290334: Update FreeType to 2.12.1
  • a747955: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 186745e: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • 2a5a30b: 8284358: Unreachable loop is not removed from C2 IR, leading to a broken graph
  • cd6f659: 8282351: jpackage does not work if class file has $$ in the name on windows
  • 37c9cd1: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
  • 6fa5281: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 25ad9d6: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/c929865666247c62e1d0da70182ea4abed95a5af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@jankratochvil
Copy link
Contributor Author

The failed macos-x64 / build is unrelated, going to notify @gdams.

@gdams
Copy link
Member

gdams commented Jul 21, 2022

The failed macos-x64 / build is unrelated, going to notify @gdams.

@jankratochvil That's a weird error, looks like wget had a moment of craziness. Can you try restarting the failed build?

@jankratochvil
Copy link
Contributor Author

All the pre-submit checks have passed now (incl. macos-x64 after its restart).

@jankratochvil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@jankratochvil
Your change (at version 645ec3f) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Jul 29, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

Going to push as commit 27ffd83.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 2e12c18: 8290334: Update FreeType to 2.12.1
  • a747955: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 186745e: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • 2a5a30b: 8284358: Unreachable loop is not removed from C2 IR, leading to a broken graph
  • cd6f659: 8282351: jpackage does not work if class file has $$ in the name on windows
  • 37c9cd1: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
  • 6fa5281: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 25ad9d6: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/c929865666247c62e1d0da70182ea4abed95a5af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2022
@openjdk openjdk bot closed this Jul 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@yan-too @jankratochvil Pushed as commit 27ffd83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants