Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs #638

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Aug 18, 2022

clean backport. This change passes TestOverUnrolling2.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/638/head:pull/638
$ git checkout pull/638

Update a local copy of the PR:
$ git checkout pull/638
$ git pull https://git.openjdk.org/jdk17u-dev pull/638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 638

View PR using the GUI difftool:
$ git pr show -t 638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/638.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d959c22a9574359e2d5134ac8365e8a9df4f7cef 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

@phohensee
Copy link
Member

Tagged JBS issue.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@caojoshua
Your change (at version 9a82211) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Got the approval.

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 3d2d300.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@phohensee @caojoshua Pushed as commit 3d2d300.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants