Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283383: [macos] a11y : Screen magnifier shows extra characters (0) at the end JButton accessibility name #655

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Sep 7, 2022

Hi all,

This pull request contains a backport of commit b021d37c from the openjdk/jdk repository.

The commit being backported was authored by Alexander Zuev on 8 Jun 2022 and was reviewed by Sergey Bylokhov and Dmitry Markov.

I wish to backport it for Oracle parity.

Patch applies clean. There's no test in the patch but there is a manual one attached in JBS. WIth Jdk17u-dev, the test demonstrates the erroneous behaviour; after the patch, it is fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283383: [macos] a11y : Screen magnifier shows extra characters (0) at the end JButton accessibility name

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/655/head:pull/655
$ git checkout pull/655

Update a local copy of the PR:
$ git checkout pull/655
$ git pull https://git.openjdk.org/jdk17u-dev pull/655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 655

View PR using the GUI difftool:
$ git pr show -t 655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/655.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b021d37cec557059e288d5937a73577233b0b172 8283383: [macos] a11y : Screen magnifier shows extra characters (0) at the end JButton accessibility name Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283383: [macos] a11y : Screen magnifier shows extra characters (0) at the end JButton accessibility name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2022

Webrevs

@jmtd
Copy link
Author

jmtd commented Sep 7, 2022

GitHub CI failure for macos-aarch64 seems unrelated:

Error: sh][ERROR] wget exited with exit code 4

@jmtd
Copy link
Author

jmtd commented Sep 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

Going to push as commit cd7da2d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2022
@openjdk openjdk bot closed this Sep 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@jmtd Pushed as commit cd7da2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant