New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270848: Redundant unsafe opmask register allocation in some instruction patterns. #657
Conversation
👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into |
Webrevs
|
b90eb60
to
b7d77d0
Compare
@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@bulasevich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @dsamersoff) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
and here - pr title needs update. |
This backport pull request has now been updated with issue from the original commit. |
/sponsor |
@dsamersoff The change author (@bulasevich) must issue an |
/integrate |
@bulasevich |
/sponsor |
Going to push as commit 36dd0a7.
Your commit was automatically rebased without conflicts. |
@dsamersoff @bulasevich Pushed as commit 36dd0a7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There was no backport request nor approval... |
Backport 71ca0c08f09e87673f1cf3f918a0802961359166
The change checks specific avx features instead of common UseAVX flag.
The change is required for JDK-8281146 backport to land cleanly in x86 ad files.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/657/head:pull/657
$ git checkout pull/657
Update a local copy of the PR:
$ git checkout pull/657
$ git pull https://git.openjdk.org/jdk17u-dev pull/657/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 657
View PR using the GUI difftool:
$ git pr show -t 657
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/657.diff