Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check #660

Closed
wants to merge 2 commits into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Sep 8, 2022

Original patch applies cleanly.

Testing: jtreg tier1, tier2, applications/jcstress on 64-core machine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/660/head:pull/660
$ git checkout pull/660

Update a local copy of the PR:
$ git checkout pull/660
$ git pull https://git.openjdk.org/jdk17u-dev pull/660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 660

View PR using the GUI difftool:
$ git pr show -t 660

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/660.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2022

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d810ad6912b7bca03e212b604cf60412da11c18 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2022

Webrevs

@dchuyko
Copy link
Member Author

dchuyko commented Sep 13, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@dchuyko
Your change (at version 49f1141) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 13, 2022

Going to push as commit b196bc4.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 061ddca: 8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes
  • 486cffe: 8282347: AARCH64: Untaken branch in has_negatives stub
  • 36dd0a7: 8270848: Redundant unsafe opmask register allocation in some instruction patterns.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2022
@openjdk openjdk bot closed this Sep 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@phohensee @dchuyko Pushed as commit b196bc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants