Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable #662

Closed

Conversation

Deigue
Copy link
Contributor

@Deigue Deigue commented Sep 8, 2022

Backport changes from JDK-8288377


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/662/head:pull/662
$ git checkout pull/662

Update a local copy of the PR:
$ git checkout pull/662
$ git pull https://git.openjdk.org/jdk17u-dev pull/662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 662

View PR using the GUI difftool:
$ git pr show -t 662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/662.diff

Sorry, something went wrong.

Deigue and others added 2 commits September 7, 2022 12:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2022

👋 Welcome back Deigue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c3256414f7df049cdd6c8519fbcea0d818a1a33 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@Deigue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2022

Webrevs

@Deigue
Copy link
Contributor Author

Deigue commented Sep 12, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@Deigue
Your change (at version 9776de3) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 24, 2022

Going to push as commit f5c0fc3.
Since your change was applied there have been 51 commits pushed to the master branch:

  • ab6f746: 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
  • 5db0eea: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • eeb4562: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
  • 4efb85f: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 9cfcae0: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 7d0854b: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • 8a9420a: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
  • b75b932: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 3be9252: 8282276: Problem list failing two Robot Screen Capture tests
  • b37756e: 8262721: Add Tests to verify single iteration loops are properly optimized
  • ... and 41 more: https://git.openjdk.org/jdk17u-dev/compare/cd7da2dfe7585d694c2f1f5ad38c22c4bcc0fef8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2022
@openjdk openjdk bot closed this Sep 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 24, 2022
@openjdk
Copy link

openjdk bot commented Sep 24, 2022

@RealCLanger @Deigue Pushed as commit f5c0fc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants