Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292903: enhance round_up_power_of_2 assertion output #714

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 21, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292903: enhance round_up_power_of_2 assertion output

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/714/head:pull/714
$ git checkout pull/714

Update a local copy of the PR:
$ git checkout pull/714
$ git pull https://git.openjdk.org/jdk17u-dev pull/714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 714

View PR using the GUI difftool:
$ git pr show -t 714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/714.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d3d4397ccbfadab99fe572f0d0a8504d268a0dc 8292903: enhance round_up_power_of_2 assertion output Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292903: enhance round_up_power_of_2 assertion output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

Going to push as commit bdabf8e.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 690ac70: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • 2bdea0f: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • c59f741: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
  • 6e40c5c: 8277358: Accelerate CRC32-C

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2022
@openjdk openjdk bot closed this Sep 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@MBaesken Pushed as commit bdabf8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant