Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java #719

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 21, 2022

I backport this for parity with 17.0.6-oracle.

I included the hunk for ClippedImages.java from "8270058: Use Objects.check{Index,FromIndexSize} for java.desktop"
which is a useful cleanup and makes the change apply clean.
All of 8270058 is not useful in 17 as it changes jdk files and depends on an intrinsic not available.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/719/head:pull/719
$ git checkout pull/719

Update a local copy of the PR:
$ git checkout pull/719
$ git pull https://git.openjdk.org/jdk17u-dev pull/719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 719

View PR using the GUI difftool:
$ git pr show -t 719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/719.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 57a76708864c3fed5fc2543f6a8552f38670488c 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c59f741: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
  • 6e40c5c: 8277358: Accelerate CRC32-C

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Sep 26, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

Going to push as commit 0c551b6.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 6230aa8: 8286551: JDK-8286460 causes tests to fail to compile in Tier2
  • 3b48de5: 8286460: Remove dependence on JAR filename in CDS tests
  • a0ccdbf: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • ae5f2de: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • f5c0fc3: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable
  • ab6f746: 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
  • 5db0eea: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • eeb4562: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
  • 4efb85f: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 9cfcae0: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/4b0ec09abc8d55ac7b89a85926f1f570489b67fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2022
@openjdk openjdk bot closed this Sep 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2022
@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@GoeLin Pushed as commit 0c551b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285612 branch September 26, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants