New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows #774
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Pre-submit test failures need investigation. |
Restarted checks, all fine. macos error was agent timeout, |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit eea78cf.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit eea78cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for https://bugs.openjdk.org/browse/JDK-6829250
Clean backport, parity with 17.0.6-oracle
Trivial test fix.
Checked manually on Windows, test passes.
Pipelines with tier1, tier2 ok.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/774/head:pull/774
$ git checkout pull/774
Update a local copy of the PR:
$ git checkout pull/774
$ git pull https://git.openjdk.org/jdk17u-dev pull/774/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 774
View PR using the GUI difftool:
$ git pr show -t 774
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/774.diff