Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287740: NSAccessibilityShowMenuAction not working for text editors #830

Closed
wants to merge 1 commit into from

Conversation

rgithubli
Copy link
Contributor

@rgithubli rgithubli commented Oct 25, 2022

Original commit: openjdk/jdk@b6cdfd6

JBS: https://bugs.openjdk.org/browse/JDK-8287740

Clean backport.

Tested locally. Ran test/jdk/java/awt/a11y/AccessibleActionsTest.java. Can see pop up menu with One, Two, Three items.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287740: NSAccessibilityShowMenuAction not working for text editors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/830/head:pull/830
$ git checkout pull/830

Update a local copy of the PR:
$ git checkout pull/830
$ git pull https://git.openjdk.org/jdk17u-dev pull/830/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 830

View PR using the GUI difftool:
$ git pr show -t 830

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/830.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6cdfd685d0cea308b15558e2dc607a680c89dc0 8287740: NSAccessibilityShowMenuAction not working for text editors Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287740: NSAccessibilityShowMenuAction not working for text editors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • eef3c96: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • e609398: 8287011: Improve container information
  • d5fedc5: 8244670: convert clhsdb "whatis" command from javascript to java
  • 5fa5392: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0698930: 8295288: Some vm_flags tests associate with a wrong BugID
  • 9fd15d5: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 6a45f75: 8280948: Write a regression test for JDK-4659800
  • aa98d09: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 9732004: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
  • 8194120: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
  • ... and 24 more: https://git.openjdk.org/jdk17u-dev/compare/fe4819b5eb25e97b459aded9e1ab93586445b301...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2022
@rgithubli rgithubli marked this pull request as ready for review November 1, 2022 20:48
@rgithubli
Copy link
Contributor Author

Still running git hub action: https://github.com/rgithubli/jdk17u-dev/actions/workflows/main.yml

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2022

Webrevs

@phohensee
Copy link
Member

JBS issue tagged

@rgithubli
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@rgithubli
Your change (at version 8f1ca9c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

Going to push as commit 092be50.
Since your change was applied there have been 35 commits pushed to the master branch:

  • b37d7df: 8275569: Add linux-aarch64 to test-make profiles
  • eef3c96: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • e609398: 8287011: Improve container information
  • d5fedc5: 8244670: convert clhsdb "whatis" command from javascript to java
  • 5fa5392: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0698930: 8295288: Some vm_flags tests associate with a wrong BugID
  • 9fd15d5: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 6a45f75: 8280948: Write a regression test for JDK-4659800
  • aa98d09: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 9732004: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
  • ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/fe4819b5eb25e97b459aded9e1ab93586445b301...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2022
@openjdk openjdk bot closed this Nov 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@phohensee @rgithubli Pushed as commit 092be50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgithubli rgithubli deleted the 8287740 branch November 4, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants