Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284533: Improve InterpreterCodelet data footprint #878

Closed
wants to merge 1 commit into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Nov 10, 2022

Original patch does not apply because of different NOT_PRODUCT fields of InterpreterCodelet. Repeated exactly the meaningful part: moving 3 fields in a new order after the NOT_PRODUCT part. Comments and white space 'after' are just like in the original diff.

Testing: tier1, tier2 on aarch64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284533: Improve InterpreterCodelet data footprint

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/878/head:pull/878
$ git checkout pull/878

Update a local copy of the PR:
$ git checkout pull/878
$ git pull https://git.openjdk.org/jdk17u-dev pull/878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 878

View PR using the GUI difftool:
$ git pr show -t 878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/878.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2022

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61698bd137fc8ffad6a63b57b73df699712527b9 8284533: Improve InterpreterCodelet data footprint Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 10, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284533: Improve InterpreterCodelet data footprint

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 10b7a6d: 8289524: Add JFR JIT restart event
  • 8ce7bb4: 8029633: Raw inner class constructor ref should not perform diamond inference
  • cfedd3f: 8294307: ISO 4217 Amendment 173 Update
  • 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • b5710c4: 8296108: (tz) Update Timezone Data to 2022f
  • f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
  • cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
  • 3d18b23: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
  • ... and 40 more: https://git.openjdk.org/jdk17u-dev/compare/996c0e9317ae9ff0b4ad88d4d050caf2ecf64811...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2022
@dchuyko
Copy link
Member Author

dchuyko commented Nov 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@dchuyko
Your change (at version e1a7eef) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

Going to push as commit 32aec43.
Since your change was applied there have been 51 commits pushed to the master branch:

  • d4d4dbc: 8295419: JFR: Change name of jdk.JitRestart
  • 10b7a6d: 8289524: Add JFR JIT restart event
  • 8ce7bb4: 8029633: Raw inner class constructor ref should not perform diamond inference
  • cfedd3f: 8294307: ISO 4217 Amendment 173 Update
  • 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • b5710c4: 8296108: (tz) Update Timezone Data to 2022f
  • f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
  • cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
  • ... and 41 more: https://git.openjdk.org/jdk17u-dev/compare/996c0e9317ae9ff0b4ad88d4d050caf2ecf64811...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2022
@openjdk openjdk bot closed this Nov 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@phohensee @dchuyko Pushed as commit 32aec43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants